From: Junio C Hamano <gitster@pobox.com>
To: pasky@suse.cz
Cc: git@vger.kernel.org, barkalow@iabervon.org
Subject: Re: [PATCH] Fail properly when cloning from invalid HTTP URL
Date: Wed, 06 Aug 2008 17:24:41 -0700 [thread overview]
Message-ID: <7v63qdn03a.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1218067590-31590-1-git-send-email-pasky@suse.cz> (pasky@suse.cz's message of "Thu, 7 Aug 2008 02:06:30 +0200")
pasky@suse.cz writes:
> diff --git a/transport.c b/transport.c
> index 6eb65b8..b88b89b 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -464,16 +464,15 @@ static struct ref *get_refs_via_curl(struct transport *transport)
> if (results.curl_result != CURLE_OK) {
> strbuf_release(&buffer);
> if (missing_target(&results)) {
> + die("%s not found: did you run git update-server-info on the server?", refs_url);
> return NULL;
Hmm, I do not see a deletion of a line here...
Everybody else in the get_refs_via_ family just die()s, and the caller of
them do not notice nor treat NULL as anything special; I think your patch
is a sensible thing to do.
next prev parent reply other threads:[~2008-08-07 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 0:06 [PATCH] Fail properly when cloning from invalid HTTP URL pasky
2008-08-07 0:24 ` Junio C Hamano [this message]
2008-08-07 14:10 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63qdn03a.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).