From: Junio C Hamano <gitster@pobox.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "SZEDER Gábor" <szeder@ira.uka.de>, git@vger.kernel.org
Subject: [PATCH 1/2] builtin-branch.c: remove unused code in append_ref() callback function
Date: Wed, 23 Jul 2008 15:09:12 -0700 [thread overview]
Message-ID: <7v63qwb6d3.fsf_-_@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vy73seb2p.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 23 Jul 2008 10:59:10 -0700")
We let for_each_ref() to feed all refs to append_ref() but we are only
ever interested in local or remote tracking branches.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
* I ended up splitting the patch into two, not three as I originally
thought I would.
builtin-branch.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/builtin-branch.c b/builtin-branch.c
index b885bd1..3708a50 100644
--- a/builtin-branch.c
+++ b/builtin-branch.c
@@ -22,10 +22,8 @@ static const char * const builtin_branch_usage[] = {
NULL
};
-#define REF_UNKNOWN_TYPE 0x00
#define REF_LOCAL_BRANCH 0x01
#define REF_REMOTE_BRANCH 0x02
-#define REF_TAG 0x04
static const char *head;
static unsigned char head_sha1[20];
@@ -215,7 +213,7 @@ static int append_ref(const char *refname, const unsigned char *sha1, int flags,
{
struct ref_list *ref_list = (struct ref_list*)(cb_data);
struct ref_item *newitem;
- int kind = REF_UNKNOWN_TYPE;
+ int kind;
int len;
static struct commit_list branch;
@@ -226,10 +224,8 @@ static int append_ref(const char *refname, const unsigned char *sha1, int flags,
} else if (!prefixcmp(refname, "refs/remotes/")) {
kind = REF_REMOTE_BRANCH;
refname += 13;
- } else if (!prefixcmp(refname, "refs/tags/")) {
- kind = REF_TAG;
- refname += 10;
- }
+ } else
+ return 0;
/* Filter with with_commit if specified */
if (!has_commit(sha1, ref_list->with_commit))
--
1.6.0.rc0.31.g128c7
next prev parent reply other threads:[~2008-07-23 22:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 13:05 q: faster way to integrate/merge lots of topic branches? Ingo Molnar
2008-07-23 13:17 ` Ingo Molnar
2008-07-23 13:49 ` Ingo Molnar
2008-07-23 14:47 ` Jay Soffian
2008-07-23 14:56 ` Ingo Molnar
2008-07-23 15:06 ` Ingo Molnar
2008-07-23 13:40 ` Andreas Ericsson
2008-07-23 14:02 ` Ingo Molnar
2008-07-23 14:57 ` Miklos Vajna
2008-07-23 13:41 ` Sergey Vlasov
2008-07-23 14:09 ` Ingo Molnar
2008-07-23 14:14 ` Ingo Molnar
2008-07-23 13:56 ` SZEDER Gábor
2008-07-23 14:04 ` Ingo Molnar
2008-07-23 17:59 ` Junio C Hamano
2008-07-23 22:09 ` Junio C Hamano [this message]
2008-07-23 22:15 ` [PATCH] builtin-branch.c: optimize --merged and --no-merged Junio C Hamano
2008-07-24 7:16 ` Lars Hjemli
2008-07-24 8:29 ` Nanako Shiraishi
2008-07-24 10:03 ` Lars Hjemli
2008-07-24 15:29 ` q: faster way to integrate/merge lots of topic branches? Ingo Molnar
2008-07-23 18:04 ` Linus Torvalds
2008-07-23 18:12 ` Linus Torvalds
2008-07-23 20:01 ` Junio C Hamano
2008-07-24 15:27 ` Ingo Molnar
2008-07-25 8:46 ` Junio C Hamano
2008-07-23 14:06 ` Björn Steinbrink
2008-07-23 14:06 ` Santi Béjar
2008-07-23 17:59 ` Linus Torvalds
2008-07-23 19:09 ` Pierre Habouzit
2008-07-23 20:27 ` Pierre Habouzit
2008-07-23 20:40 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63qwb6d3.fsf_-_@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).