From: Junio C Hamano <gitster@pobox.com>
To: "Philippe Bruhat (BooK)" <book@cpan.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] mailinfo: better parse email adresses containg parentheses
Date: Mon, 21 Jul 2008 20:16:43 -0700 [thread overview]
Message-ID: <7v63qyr4kk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1216647269-12287-1-git-send-email-book@cpan.org> (Philippe Bruhat's message of "Mon, 21 Jul 2008 15:34:29 +0200")
"Philippe Bruhat (BooK)" <book@cpan.org> writes:
> When using git-rebase, author fields containing a ')' at the last
> position had the close-parens character incorrectly removed
> because the From: parser incorrectly matched it as
>
> user@host (User Name)
>
> (removing parentheses), instead of
>
> User Name (me) <user@host>
>
> Signed-off-by: Philippe Bruhat (BooK) <book@cpan.org>
Hmm, tests?
By the way, that second form parses like this:
mailbox =
name-addr =
display-name angle-addr = "User Name (me) <user@host>"
display-name =
phrase = "User Name"
angle-addr = CFWS "<" addr-spec ">" = "(me) <user@host>"
So strictly speaking, shouldn't we be stripping the whole (me) as garbage?
It is not even part of the display-name but is a whitespace equivalent
comment.
next prev parent reply other threads:[~2008-07-22 3:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 13:34 [PATCH] mailinfo: better parse email adresses containg parentheses Philippe Bruhat (BooK)
2008-07-21 14:36 ` Lukas Sandström
2008-07-22 3:16 ` Junio C Hamano [this message]
2008-07-22 10:24 ` Philippe Bruhat (BooK)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63qyr4kk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=book@cpan.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).