From: Junio C Hamano <gitster@pobox.com>
To: "Mikael Magnusson" <mikachu@gmail.com>
Cc: "Jeff King" <peff@peff.net>, "Lea Wiemann" <lewiemann@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [Bug] for-each-ref: %(object) and %(type) unimplemented
Date: Wed, 25 Jun 2008 12:38:59 -0700 [thread overview]
Message-ID: <7v63rx1ezw.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <237967ef0806251208u65c17652gc6091da98294f807@mail.gmail.com> (Mikael Magnusson's message of "Wed, 25 Jun 2008 21:08:30 +0200")
"Mikael Magnusson" <mikachu@gmail.com> writes:
> 2008/6/25 Jeff King <peff@peff.net>:
>> On Wed, Jun 25, 2008 at 12:08:15PM -0400, Jeff King wrote:
>>
>>> Since you seem to be testing for-each-ref, maybe it would make sense to
>>> put together a test script that exercises each of the atoms?
>>
>> Hmm. Actually, there is a test in t6300 that runs with each atom name.
>> Unfortunately, it doesn't bother actually checking the output for
>> sanity, so the fact that these atoms returned the empty string was
>> missed.
>
> The documentation also says "tree" and "parent" should work (which they
> also don't).
The doc does not say any such thing. A tag object does not have 'parent'
nor 'tree' header fields.
Neither a commit have 'object' nor 'type' header fields and you cannot ask
for them when showing a commit object.
next prev parent reply other threads:[~2008-06-25 19:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 15:01 [Bug] for-each-ref: %(object) and %(type) unimplemented Lea Wiemann
2008-06-25 16:08 ` Jeff King
2008-06-25 16:14 ` Jeff King
2008-06-25 19:08 ` Mikael Magnusson
2008-06-25 19:38 ` Junio C Hamano [this message]
2008-06-25 20:36 ` Mikael Magnusson
2008-06-26 5:35 ` Jeff King
2008-06-26 5:37 ` [PATCH 1/2] improve for-each-ref test script Jeff King
2008-06-26 5:38 ` [PATCH 2/2] for-each-ref: implement missing tag values Jeff King
2008-06-26 8:08 ` [Bug] for-each-ref: %(object) and %(type) unimplemented Jeff King
2008-06-26 8:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63rx1ezw.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lewiemann@gmail.com \
--cc=mikachu@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).