From: Junio C Hamano <gitster@pobox.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] filter-branch.sh: support nearly proper tag name filtering
Date: Mon, 24 Mar 2008 18:14:21 -0700 [thread overview]
Message-ID: <7v63vbr4eq.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <47E8267D.5000405@nrlssc.navy.mil> (Brandon Casey's message of "Mon, 24 Mar 2008 17:09:01 -0500")
Brandon Casey <casey@nrlssc.navy.mil> writes:
> I learned that the 'Q' command to sed is not portable, and most versions
> of sed require a newline after 'c\' like commands.
Both true. If you want to be portable to esoteric ones (I suffered AIX
while hacking on autoconf long time ago), sed is a bitch to get right.
What I meant with my earlier comment was that it would have been more
robust if you did a sequence of:
s/type .*/type $newtype/
s/object .*/object $newobject/
instead of relying on the order in the existing objects, but I should have
been more explicit about c\ as well.
next prev parent reply other threads:[~2008-03-25 1:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1206031893-29599-1-git-send-email-casey@nrlssc.navy.mil>
2008-03-20 17:02 ` [PATCH 2/2] filter-branch.sh: support nearly proper tag name filtering Brandon Casey
2008-03-20 17:14 ` Johannes Schindelin
2008-03-20 17:38 ` Brandon Casey
2008-03-24 5:49 ` Junio C Hamano
2008-03-24 10:53 ` Johannes Schindelin
2008-03-24 14:49 ` Junio C Hamano
2008-03-24 15:10 ` Johannes Schindelin
2008-03-24 16:34 ` Brandon Casey
2008-03-24 16:45 ` Brandon Casey
2008-03-24 16:46 ` Johannes Schindelin
2008-03-24 17:06 ` Brandon Casey
2008-03-24 17:14 ` Johannes Schindelin
2008-03-24 18:37 ` Brandon Casey
2008-03-24 21:22 ` filter-branch --all? Eyvind Bernhardsen
2008-03-24 21:33 ` Brandon Casey
2008-03-24 21:44 ` Eyvind Bernhardsen
2008-03-24 19:02 ` [PATCH 2/2] filter-branch.sh: support nearly proper tag name filtering Brandon Casey
2008-03-24 22:09 ` [PATCH] " Brandon Casey
2008-03-24 22:14 ` Brandon Casey
2008-03-25 1:14 ` Junio C Hamano [this message]
2008-03-25 15:44 ` [PATCH v3] " Brandon Casey
2008-03-26 7:57 ` Junio C Hamano
2008-03-26 15:47 ` [PATCH v4] " Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63vbr4eq.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).