From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Force new line at end of commit message Date: Sun, 30 Dec 2007 02:51:45 -0800 Message-ID: <7v63yga20u.fsf@gitster.siamese.dyndns.org> References: <87ve6ub3u7.fsf@gollum.intra.norang.ca> <8763yof9lg.fsf@gollum.intra.norang.ca> <20071225044202.GO14735@spearce.org> <7v4pe5nt8m.fsf@gitster.siamese.dyndns.org> <7vodc99gpy.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Shawn O. Pearce" , Bernt Hansen , git@vger.kernel.org To: Johannes Schindelin X-From: git-owner@vger.kernel.org Sun Dec 30 11:52:41 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1J8vma-0005FK-Nm for gcvg-git-2@gmane.org; Sun, 30 Dec 2007 11:52:41 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751669AbXL3KwJ (ORCPT ); Sun, 30 Dec 2007 05:52:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751674AbXL3KwI (ORCPT ); Sun, 30 Dec 2007 05:52:08 -0500 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:63891 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbXL3KwH (ORCPT ); Sun, 30 Dec 2007 05:52:07 -0500 Received: from a-sasl-quonix (localhost [127.0.0.1]) by a-sasl-quonix.pobox.com (Postfix) with ESMTP id 784BD6943; Sun, 30 Dec 2007 05:52:01 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-quonix.pobox.com (Postfix) with ESMTP id E04F56941; Sun, 30 Dec 2007 05:51:54 -0500 (EST) In-Reply-To: (Johannes Schindelin's message of "Sun, 30 Dec 2007 11:26:49 +0100 (CET)") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Johannes Schindelin writes: > But if I understood the OP correctly, the problem was a missing newline at > the end of the commit message, no? That's why the "echo" was moved out of the conditional, to make sure "# This is the $(nth)" begins on a fresh line.