From: Junio C Hamano <gitster@pobox.com>
To: "Marco Costalba" <mcostalba@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Speedup prefixcmp() common case
Date: Sat, 29 Dec 2007 11:32:48 -0800 [thread overview]
Message-ID: <7v63yhb8kf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <e5bfff550712291001q5f246ceah6700b98308fb96f1@mail.gmail.com> (Marco Costalba's message of "Sat, 29 Dec 2007 19:01:08 +0100")
"Marco Costalba" <mcostalba@gmail.com> writes:
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 79eb10e..e26b684 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -398,6 +398,10 @@ static inline int sane_case
>
> static inline int prefixcmp(const char *str, const char *prefix)
> {
> + // shortcut common case of a single char prefix
> + if (prefix && *(prefix + 1) == '\0' && str)
> + return *str - *prefix;
> +
Why isn't it like this?
if (!prefix[1])
return *str - *prefix;
> return strncmp(str, prefix, strlen(prefix));
> }
>
> --
> 1.5.4.rc2-dirty
next prev parent reply other threads:[~2007-12-29 19:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-29 18:01 [PATCH] Speedup prefixcmp() common case Marco Costalba
2007-12-29 19:22 ` [PATCH] Optimize prefixcmp() Johannes Schindelin
2007-12-29 20:39 ` Marco Costalba
2007-12-29 22:15 ` Johannes Schindelin
2007-12-29 22:44 ` Marco Costalba
2007-12-30 13:02 ` Marco Costalba
2007-12-30 13:55 ` Pierre Habouzit
2007-12-30 13:58 ` Pierre Habouzit
2007-12-30 14:50 ` Marco Costalba
2007-12-30 15:17 ` Marco Costalba
2007-12-30 15:54 ` Johannes Schindelin
2007-12-29 21:54 ` Andy Parkins
2007-12-30 0:44 ` Junio C Hamano
2008-01-02 16:59 ` René Scharfe
2008-01-02 18:52 ` Junio C Hamano
2008-01-03 0:45 ` René Scharfe
2007-12-29 19:32 ` Junio C Hamano [this message]
2007-12-29 20:14 ` [PATCH] Speedup prefixcmp() common case Marco Costalba
2007-12-30 0:05 ` Junio C Hamano
2007-12-29 20:43 ` Marco Costalba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63yhb8kf.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mcostalba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).