From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Thomas Harning <harningt@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] add status.relativePaths config variable
Date: Sat, 08 Dec 2007 00:05:49 -0800 [thread overview]
Message-ID: <7v63z9y5k2.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071208080238.GB4812@coredump.intra.peff.net> (Jeff King's message of "Sat, 8 Dec 2007 03:02:38 -0500")
Jeff King <peff@peff.net> writes:
> On Fri, Dec 07, 2007 at 11:47:56PM -0800, Junio C Hamano wrote:
>
>> Which would make the rewritten patch like this...
>
> Looks like our patches just crossed paths. Yours looks OK, but we
> should add something to the 'configuration' section, and...
>
>> diff --git a/wt-status.h b/wt-status.h
>> index 225fb4d..63d50f2 100644
>> --- a/wt-status.h
>> +++ b/wt-status.h
>> @@ -28,6 +28,7 @@ struct wt_status {
>>
>> int git_status_config(const char *var, const char *value);
>> int wt_status_use_color;
>> +int wt_status_relative_paths;
>> void wt_status_prepare(struct wt_status *s);
>> void wt_status_print(struct wt_status *s);
>
> Shouldn't both of these ints be marked "extern"? I'm surprised it worked
> at all (or perhaps the part of my brain that stores C linkage issues is
> rotting?).
Yes, rotting very much.
next prev parent reply other threads:[~2007-12-08 8:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 16:57 [PATCH] quote_path: convert empty path to "./" Jeff King
2007-12-07 18:54 ` Johannes Schindelin
2007-12-07 19:05 ` Thomas Harning
2007-12-07 20:49 ` Jeff King
2007-12-07 21:26 ` [PATCH] add status.relativePaths config variable Jeff King
2007-12-08 7:34 ` Junio C Hamano
2007-12-08 7:47 ` Junio C Hamano
2007-12-08 8:02 ` Jeff King
2007-12-08 8:05 ` Junio C Hamano [this message]
2007-12-08 8:45 ` Jeff King
2007-12-08 7:55 ` Jeff King
2007-12-08 8:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63z9y5k2.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=harningt@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).