Re: [PATCH] Set OLD_ICONV on Cygwin.

Re: [PATCH] Set OLD_ICONV on Cygwin.

[Pascal Obry]

Andreas Ericsson wrote:
> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.

Hum, I don't think this is a requirement. At least nothing is said about
CCing Junio on the Git Web site.

Anyway, now Junio is CCed :)

Pascal.

Re: [PATCH] Set OLD_ICONV on Cygwin.

[Andreas Ericsson]

Pascal Obry wrote:
> Andreas Ericsson wrote:
>> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.
> 
> Hum, I don't think this is a requirement. At least nothing is said about
> CCing Junio on the Git Web site.
> 

It's not a requirement, but he won't act on things he doesn't see, and CC'ing
him directly is the recommended way of getting his attention. Most people do
so for patches that aren't directly related to a sub-part of git primarily
maintained by someone else (Shawn O. Pearce for git-gui, Eric Wong for git-svn,
etc., etc.)

> Anyway, now Junio is CCed :)
> 

Nice. If my suspicions are correct and he missed your patch the first time
around, you should probably resend it though.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Re: [PATCH] Set OLD_ICONV on Cygwin.

[Junio C Hamano]

Andreas Ericsson <ae@op5.se> writes:

> Nice. If my suspicions are correct and he missed your patch the first time
> around, you should probably resend it though.

I still have it in my mailbox.

I saw the patch but saw nobody else said about the patch being helpful
to his installation, nor more importantly, "Good, this won't hurt for me
who run a different vintage of Cygwin", and I was waiting for such
confirmations.

Then nobody responded, so I forgot.

That was what happened the first time Pascal's patch was posted.

Re: [PATCH] Set OLD_ICONV on Cygwin.

[Junio C Hamano]

Junio C Hamano <gitster@pobox.com> writes:

> Andreas Ericsson <ae@op5.se> writes:
>
>> Nice. If my suspicions are correct and he missed your patch the first time
>> around, you should probably resend it though.
>
> I still have it in my mailbox.
>
> I saw the patch but saw nobody else said about the patch being helpful
> to his installation, nor more importantly, "Good, this won't hurt for me
> who run a different vintage of Cygwin", and I was waiting for such
> confirmations.
>
> Then nobody responded, so I forgot.
>
> That was what happened the first time Pascal's patch was posted.

I think the patch is fine; I just checked with my copy of Cygwin that I
haven't fired for some time (it was a pain waiting for it to update to
the latest set of git sources).

I am at work and will be busy for the rest of the afternoon, so won't be
applying it until this evening, though.

Re: [PATCH] Set OLD_ICONV on Cygwin.

[Pascal Obry]

Junio C Hamano a écrit :
> I am at work and will be busy for the rest of the afternoon, so won't be
> applying it until this evening, though.

Ok, thanks. No urgency with this patch anyway.

Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595

[PATCH] Set OLD_ICONV on Cygwin.

[Pascal Obry]

Cygwin still has old definition for the iconv() second
parameter. This patch fixes the last warning on Cygwin.
This has been tested with Cygwin 1.5.24.

Signed-off-by: Pascal Obry <pascal@obry.net>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index e869b85..fa3398c 100644
--- a/Makefile
+++ b/Makefile
@@ -446,6 +446,7 @@ ifeq ($(uname_O),Cygwin)
 	NEEDS_LIBICONV = YesPlease
 	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
 	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
+	OLD_ICONV = UnfortunatelyYes
 	# There are conflicting reports about this.
 	# On some boxes NO_MMAP is needed, and not so elsewhere.
 	# Try commenting this out if you suspect MMAP is more efficient
-- 
1.5.3.6.985.g65c6a4

Re: [PATCH] Set OLD_ICONV on Cygwin.

[Pascal Obry]

I pretty well understand that this patch is not very important but since
I got no reply I'm wondering if there is something wrong with it ?

Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595

Re: [PATCH] Set OLD_ICONV on Cygwin.

[Andreas Ericsson]

Pascal Obry wrote:
> I pretty well understand that this patch is not very important but since
> I got no reply I'm wondering if there is something wrong with it ?
> 

Only one, insofar as I can see; You didn't CC Junio. He probably missed it.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231