From: Junio C Hamano <gitster@pobox.com>
To: Pini Reznik <pinir@expand.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Open external merge tool with original file extensions in all three files
Date: Mon, 03 Dec 2007 10:17:23 -0800 [thread overview]
Message-ID: <7v63zfiqx8.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1196695874-22567-1-git-send-email-pinir@expand.com
Pini Reznik <pinir@expand.com> writes:
> This required to be able to use syntax highlighting in meld during
> conflicts resolution....
> + extension=`echo $path | awk -F \. '{print $NF}'`
> + BACKUP="$path.BACKUP.$$.${extension}"
> + LOCAL="$path.LOCAL.$$.${extension}"
> + REMOTE="$path.REMOTE.$$.${extension}"
> + BASE="$path.BASE.$$.${extension}"
I had to wonder what would happen in these cases:
* path = "a/b/c/d"
* path = "a/b.c/d"
I also think spawning awk for this is way overkill.
next prev parent reply other threads:[~2007-12-03 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 15:31 [PATCH] Open external merge tool with original file extensions in all three files Pini Reznik
2007-12-03 18:17 ` Junio C Hamano [this message]
2007-12-03 21:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63zfiqx8.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pinir@expand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).