From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH] avoid "defined but not used" warning for fetch_objs_via_walker
Date: Tue, 20 Nov 2007 23:10:53 -0800 [thread overview]
Message-ID: <7v63zwhy4i.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071118081722.GA31563@sigill.intra.peff.net> (Jeff King's message of "Sun, 18 Nov 2007 03:17:23 -0500")
Jeff King <peff@peff.net> writes:
> Because this function is static and used only by the
> http-walker, when NO_CURL is defined, gcc emits a "defined
> but not used" warning.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> On master. I like to compile with -Werror to make sure I don't miss
> warnings as the compile scrolls by.
>
> This fix feels a little wrong, since the function isn't specific to http
> support, but hopefully the comment should be obvious if we ever add
> another similar commit walker that needs it.
Yeah, while I share your -Werror desire it sure feels a bit
dirty. As it does not look like we will be taking any new
walkers, I think your patch is reasonable, though.
next prev parent reply other threads:[~2007-11-21 7:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 8:17 [PATCH] avoid "defined but not used" warning for fetch_objs_via_walker Jeff King
2007-11-21 7:10 ` Junio C Hamano [this message]
2007-11-21 18:05 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63zwhy4i.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).