From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Daniel Barkalow <barkalow@iabervon.org>,
git@vger.kernel.org, Alex Riesen <raa.lkml@gmail.com>,
Pierre Habouzit <madcoder@debian.org>
Subject: Re: [PATCH 1/3] send-pack: track errors for each ref
Date: Sat, 17 Nov 2007 17:21:59 -0800 [thread overview]
Message-ID: <7v6400z6tk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071118001312.GB4000@sigill.intra.peff.net> (Jeff King's message of "Sat, 17 Nov 2007 19:13:14 -0500")
Jeff King <peff@peff.net> writes:
> On Sat, Nov 17, 2007 at 01:05:35PM -0500, Daniel Barkalow wrote:
>
>> > + if (ref->nonfastforward) {
>> > + strcat(quickref, "...");
>> > + type = '+';
>> > + msg = " (forced update)";
>> > + }
>> > + else {
>>
>> Coding style, IIRC.
>
> Sorry, I don't see the style nit you're mentioning here.
I think Daniel is referring to "Put 'else' on the same line as
the brace that closes the corresponding 'if' opened", iow:
if (...) {
...
} else {
...
}
next prev parent reply other threads:[~2007-11-18 1:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 12:53 [PATCH v3 0/3] tracking per-ref errors on push Jeff King
2007-11-17 12:54 ` [PATCH 1/3] send-pack: track errors for each ref Jeff King
2007-11-17 13:34 ` Alex Riesen
2007-11-17 18:05 ` Daniel Barkalow
2007-11-18 0:13 ` Jeff King
2007-11-18 1:21 ` Junio C Hamano [this message]
2007-11-18 3:12 ` Jeff King
2007-11-17 20:53 ` Junio C Hamano
2007-11-18 0:15 ` Jeff King
2007-11-17 12:55 ` [PATCH 2/3] send-pack: check ref->status before updating tracking refs Jeff King
2007-11-17 13:45 ` Alex Riesen
2007-11-17 13:53 ` Jeff King
2007-11-17 18:05 ` Daniel Barkalow
2007-11-17 12:56 ` [PATCH 3/3] send-pack: assign remote errors to each ref Jeff King
2007-11-17 18:05 ` Daniel Barkalow
2007-11-18 0:03 ` Jeff King
2007-11-18 1:03 ` Junio C Hamano
2007-11-18 2:39 ` Jeff King
2007-11-18 4:47 ` Junio C Hamano
2007-11-18 5:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v6400z6tk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).