git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Julian Phillips <julian@quantumfyre.co.uk>
Cc: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>,
	git@vger.kernel.org,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: name-rev does not show the shortest path
Date: Fri, 24 Aug 2007 11:33:39 -0700	[thread overview]
Message-ID: <7v6434eq9o.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0708241615040.7313@reaper.quantumfyre.co.uk> (Julian Phillips's message of "Fri, 24 Aug 2007 16:21:46 +0100 (BST)")

Julian Phillips <julian@quantumfyre.co.uk> writes:

> From a quick look at the code, that's not surprising, it runs "git
> name-rev --name-only --tags" under the bonnet - so not helpful at all,
> sorry.
>
> So now I wonder how useful --contains really is ... I would have
> expected to always get the "closest" tag.  ~1009^2~1^3~5 seems closer
> than ~1686^2~1^3~5 to me ... ho hum.

The usefulness of --contains is only to provide a nicer looking
shortcut to older name-rev program, as more people are already
familiar with "git describe".  It does not improve name-rev.

I _think_ name-rev goes for shorter-to-type tags and does not
have any other heuristics.  Dscho?

  reply	other threads:[~2007-08-24 18:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-23 10:38 name-rev does not show the shortest path Uwe Kleine-König
2007-08-24 11:55 ` Julian Phillips
2007-08-24 12:52   ` Uwe Kleine-König
2007-08-24 15:21     ` Julian Phillips
2007-08-24 18:33       ` Junio C Hamano [this message]
2007-08-25 15:04         ` Johannes Schindelin
2007-08-26  9:23           ` Jeff King
2007-08-26 15:38             ` Johannes Schindelin
2007-08-27  9:24               ` Jeff King
2007-08-27  9:57                 ` Johannes Schindelin
2007-08-27 11:18                   ` Johannes Schindelin
2007-08-27 11:37 ` [PATCH] name-rev: Fix non-shortest description Johannes Schindelin
2007-08-27 19:27   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v6434eq9o.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=julian@quantumfyre.co.uk \
    --cc=ukleinek@informatik.uni-freiburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).