From: Junio C Hamano <junkio@cox.net>
To: "Ismail Dönmez" <ismail@pardus.org.tr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man
Date: Fri, 11 May 2007 12:27:35 -0700 [thread overview]
Message-ID: <7v646zb1p4.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200705112025.58095.ismail@pardus.org.tr> (Ismail Dönmez's message of "Fri, 11 May 2007 20:25:57 +0300")
Ismail Dönmez <ismail@pardus.org.tr> writes:
> On Tuesday 08 May 2007 13:49:31 you wrote:
>> Hi,
>>
>> According to FHS standard default man page path is $prefix/share/man [0] ,
>> attached patch fixes this for GIT.
>>
>> [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES
>>
>> Signed-off-by: Ismail Donmez <ismail@pardus.org.tr>
>
> ACK? NAK? Do we care about this? :)
I would not say the patch is wrong per-se, but:
- People who do not override prefix to install in $HOME would
suddenly get their mandir under $HOME/share/man; the fact
nobody complained so far suggests me that these people have
$MANPATH pointing at $HOME/man, which means your patch breaks
things for them, unless they have been overriding mandir in
which case your patch does not matter to them;
- Distros who package git and want to conform to FHS would have
been overriding not just prefix but mandir anyway, so your patch
is not an improvement to them;
- People who override prefix to install locally in /usr or
/usr/local does "make prefix=" thing anyway, and the fact
nobody complained so far suggests me that they have already
known they need to override mandir as well if they do not
like /usr/local/man, so your patch is not an improvement to
them.
That makes one half negative plus two and half neutral.
next prev parent reply other threads:[~2007-05-11 19:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 10:49 [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Ismail Dönmez
2007-05-08 15:02 ` Uwe Kleine-König
2007-05-08 15:23 ` Ismail Dönmez
2007-05-08 17:44 ` Brian Gernhardt
2007-05-11 17:25 ` Ismail Dönmez
2007-05-11 17:42 ` Linus Torvalds
2007-05-11 19:27 ` Junio C Hamano [this message]
2007-05-11 19:42 ` Ismail Dönmez
2007-05-11 19:44 ` Junio C Hamano
2007-05-11 19:50 ` Ismail Dönmez
2007-06-20 19:42 ` Ismail Dönmez
2007-06-20 20:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v646zb1p4.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=ismail@pardus.org.tr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).