From: Junio C Hamano <junkio@cox.net>
To: "Lars Hjemli" <hjemli@gmail.com>
Cc: "Junio C Hamano" <junkio@cox.net>, "Geert Bosch" <bosch@gnat.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] rename_ref(): only print a warning when config-file update fails
Date: Fri, 06 Apr 2007 17:14:57 -0700 [thread overview]
Message-ID: <7v6489hwfy.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 8c5c35580704061653x7e5fd149ud31a8289a4508b54@mail.gmail.com
"Lars Hjemli" <hjemli@gmail.com> writes:
>> I wonder if rolling back the rename that was asked is an
>> option. We would want to keep these low-level things atomic
>> whenever possible.
>
> I was wondering the same thing, i.e. "goto rollback" as an option for
> "error()". But I ended up thinking that rename_ref() shouldn't bother
> with the config file at all (thus my other patch).
I agree that "other patch" is sensible regardless.
prev parent reply other threads:[~2007-04-07 0:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 8:33 [PATCH] rename_ref(): only print a warning when config-file update fails Lars Hjemli
2007-04-06 10:35 ` Geert Bosch
2007-04-06 20:35 ` Junio C Hamano
2007-04-06 23:53 ` Lars Hjemli
2007-04-07 0:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v6489hwfy.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=bosch@gnat.com \
--cc=git@vger.kernel.org \
--cc=hjemli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).