From: Junio C Hamano <junkio@cox.net>
To: Lars Hjemli <hjemli@gmail.com>
Cc: git@vger.kernel.org, "Marco Costalba" <mcostalba@gmail.com>
Subject: Re: [PATCH] Skip excessive blank lines before commit body
Date: Wed, 03 Jan 2007 09:03:03 -0800 [thread overview]
Message-ID: <7v64booxfc.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11678312532251-git-send-email-hjemli@gmail.com> (Lars Hjemli's message of "Wed, 3 Jan 2007 14:34:13 +0100")
Lars Hjemli <hjemli@gmail.com> writes:
> This modifies pretty_print_commit() to make the output of
> git-rev-list and friends a bit more predictable.
>
> A commit body starting with blank lines might be unheard-of,
> but still possible to create using git-commit-tree (so is
> bound to appear somewhere, sometime).
This is unfortunately (!!) a good change. By design,
commit-tree should take whatever binary garbage the user throws
at it as-is (there is no requirement for it to be even text),
and the "punchline + LF + body + LF + signoffs" is strictly by
convention. We already reformat using indentations and friends,
so your change is a very sane thing to do.
We might want to tighten the formatting convention enforced at
the Porcelain level -- we can start the process by shipping a
sample commit message hook that checks a well formatted commit
log message, perhaps?
next prev parent reply other threads:[~2007-01-03 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-03 13:34 [PATCH] Skip excessive blank lines before commit body Lars Hjemli
2007-01-03 17:03 ` Junio C Hamano [this message]
2007-01-04 15:50 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v64booxfc.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=hjemli@gmail.com \
--cc=mcostalba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox