From: Junio C Hamano <junkio@cox.net>
To: Stephan Feder <sf@b-i-t.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Teach --text option to diff
Date: Fri, 07 Jul 2006 04:06:23 -0700 [thread overview]
Message-ID: <7v64i91xow.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11522684373987-git-send-email-sf@b-i-t.de> (Stephan Feder's message of "Fri, 07 Jul 2006 12:33:57 +0200")
Stephan Feder <sf@b-i-t.de> writes:
> I have to send patches of binary data to a customer but the builtin diff
> was no help in this case.
Given the previous patch, and also your point #2 below, I would
have expected you to introduce an option to force files to be
treated as binary even when they are otherwise misidentified as
text, but this patch is going the other way.
Interesting.
> 1. The shorthand -a for --text is not implemented. Is there a conflicting
> shorthand?
I do not think of one offhand, but it's the responsibility for
the party to propose such an enhancement to do the study ;-)
> 2. For diffstat --text is ignored. It seems pointless because binary
> patch data is not for human consumption anyway.
> 3. No documentation yet. If the patch is accepted I will add a short
> description. To Documentation/diff-options.txt?
Most likely that would be the place.
next prev parent reply other threads:[~2006-07-07 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 10:33 [PATCH] Teach --text option to diff Stephan Feder
2006-07-07 11:06 ` Junio C Hamano [this message]
2006-07-07 11:53 ` sf
2006-07-07 13:57 ` [PATCH 1/3] Teach diff -a as shorthand for --text Stephan Feder
2006-07-07 13:57 ` [PATCH 2/3] Add -a and --text to common diff options help Stephan Feder
2006-07-07 13:57 ` [PATCH 3/3] diff-options: Explain --text and -a Stephan Feder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v64i91xow.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=sf@b-i-t.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox