Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Yaacov Akiba Slama <ya@slamail.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/7] Using svn pools seems to solve the memory leak problem
Date: Wed, 02 Nov 2005 14:38:57 -0800	[thread overview]
Message-ID: <7v64raptdq.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <E1EXQWT-000504-Qw@localhost.localdomain> (Yaacov Akiba Slama's message of "Wed, 02 Nov 2005 23:51:57 +0200")

I see you are resending the previous round after splitting, but
could you be a bit more careful about the commit log?  One liner
title that is self-sufficient (as opposed to just the initial
part of one sentence, cut off at whereever your editor happened
to decide to fold line), which goes to Subject:, and the body of
the message as a separate paragraph.

Especially something like this (5/7) does not make much sense:

    From: Yaacov Akiba Slama <ya@slamail.org>
    Subject: [PATCH 5/7] When copying files and/or directories from several branches in one single
    Date: Wed, 02 Nov 2005 23:51:57 +0200

    revision, all these branches are used as parents of the commit.

      reply	other threads:[~2005-11-02 22:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-02 21:51 [PATCH 1/7] Using svn pools seems to solve the memory leak problem Yaacov Akiba Slama
2005-11-02 22:38 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v64raptdq.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=ya@slamail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox