Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Split up tree diff functions into tree-diff.c library
Date: Thu, 20 Oct 2005 23:16:21 -0700	[thread overview]
Message-ID: <7v64rr2y4q.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0510202058030.10477@g5.osdl.org> (Linus Torvalds's message of "Thu, 20 Oct 2005 21:05:05 -0700 (PDT)")

I have not closely studied the user of this change, rev-list,
but I have a hunch that you might be better off, if you define a
new diff "format", DIFF_FORMAT_CALLBACK, and hook into
diff_flush(), instead of hooking into diff_addremove() and
diff_change().  Instead of calling diff_flush_raw() or
diff_flush_name(), or diff_flush_patch(), your callback function
would be called with each filepair.

Right now, you are only making the parallel tree traversing and
comparing part from diff-tree available in the library form
(which is fine), but that way leaves the door open for it to
also use the rest of the diffcore machinery.

By doing things this way, later round of rev-list that culls
uninteresting commits could be taught to also follow renames.

Am I grossly off the mark?

  reply	other threads:[~2005-10-21  6:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-21  4:05 Split up tree diff functions into tree-diff.c library Linus Torvalds
2005-10-21  6:16 ` Junio C Hamano [this message]
2005-10-21 15:19   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v64rr2y4q.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox