From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Sverre Rabbelier <srabbelier@gmail.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] transport-helper: barf when user tries old:new
Date: Tue, 21 May 2013 09:32:42 -0700 [thread overview]
Message-ID: <7v7gisqonp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1369098165-8727-1-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Mon, 20 May 2013 20:02:45 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Otherwise with certain remote helpers (the ones that support 'export'),
> the users will be pushing to the wrong branch:
>
> git push topic:master
>
> Will push the topic branch, as if the user typed:
>
> git push topic
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>
> I won't
> bother rationalizing if this makes sense for 'master'
As this is a change to an old code/behaviour that was with us with
many released versions, it hardly is for 'master' during -rc period.
I think your dry-run one (the reroll) is a good fix but for the same
reason I'd rather see us apply after 1.8.3 final.
next prev parent reply other threads:[~2013-05-21 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 1:02 [PATCH] transport-helper: barf when user tries old:new Felipe Contreras
2013-05-21 16:32 ` Junio C Hamano [this message]
2013-05-21 21:12 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7gisqonp.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).