From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@suse.cz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] cherry-pick: better error message when the parameter is a non-commit
Date: Mon, 08 Apr 2013 09:45:58 -0700 [thread overview]
Message-ID: <7v7gkdynqx.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130408122750.GB5132@suse.cz> (Miklos Vajna's message of "Mon, 8 Apr 2013 14:27:50 +0200")
Miklos Vajna <vmiklos@suse.cz> writes:
> On Wed, Apr 03, 2013 at 11:27:04AM +0200, Miklos Vajna <vmiklos@suse.cz> wrote:
>> When copy&paste goes wrong, and the user e.g. tries to cherry-pick a
>> blob, the error message used to be:
>>
>> fatal: BUG: expected exactly one commit from walk
>>
>> Instead, now it is:
>>
>> fatal: Can't cherry-pick a blob
>>
>> Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
>> ---
>> sequencer.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> Ping, any comment on this patch?
Nothing in particular from me.
next prev parent reply other threads:[~2013-04-08 16:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 9:27 [PATCH] cherry-pick: better error message when the parameter is a non-commit Miklos Vajna
2013-04-08 12:27 ` Miklos Vajna
2013-04-08 16:45 ` Junio C Hamano [this message]
2013-04-08 16:56 ` Junio C Hamano
2013-04-11 9:26 ` [PATCH v2] cherry-pick: make sure all input objects are commits Miklos Vajna
2013-04-11 10:22 ` Ramkumar Ramachandra
2013-04-11 11:03 ` Miklos Vajna
2013-04-11 11:42 ` Ramkumar Ramachandra
2013-04-11 13:06 ` [PATCH v3] " Miklos Vajna
2013-04-11 13:27 ` Ramkumar Ramachandra
2013-04-15 8:44 ` Thomas Rast
2013-04-15 18:29 ` Junio C Hamano
2013-04-15 19:12 ` Junio C Hamano
2013-04-16 14:22 ` Michael Haggerty
2013-05-09 19:47 ` Junio C Hamano
2013-05-09 20:27 ` Junio C Hamano
2013-05-10 7:07 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7gkdynqx.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=vmiklos@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).