git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Christoph J. Thompson" <cjsthompson@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Honor configure's htmldir switch
Date: Sat, 02 Feb 2013 17:27:18 -0800	[thread overview]
Message-ID: <7v7gmqb30p.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130202212504.GA16412@gmail.com> (Christoph J. Thompson's message of "Sat, 2 Feb 2013 22:25:11 +0100")

"Christoph J. Thompson" <cjsthompson@gmail.com> writes:

> Honor autoconf's --htmldir switch. This allows relocating HTML docs 
> straight from the configure script.
>
>
> Signed-off-by: Christoph J. Thompson <cjsthompson@gmail.com>
> ---
>  config.mak.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/config.mak.in b/config.mak.in
> index e8a9bb4..d7c49cd 100644
> --- a/config.mak.in
> +++ b/config.mak.in
> @@ -19,6 +19,7 @@ template_dir = @datadir@/git-core/templates
>  sysconfdir = @sysconfdir@
>  
>  mandir = @mandir@
> +htmldir = @htmldir@
>  
>  srcdir = @srcdir@
>  VPATH = @srcdir@

Hmph, in the output of "git grep -e mandir config.mak.in", I see

    export exec_prefix mandir

which makes me wonder if we should either export htmldir as well, or
drop mandir from the "export".  Off-hand, I am not sure which is the
right way, but in either case the inconsistency disturbs me.

Thanks.

  reply	other threads:[~2013-02-03  1:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-02 21:25 [PATCH] Honor configure's htmldir switch Christoph J. Thompson
2013-02-03  1:27 ` Junio C Hamano [this message]
     [not found]   ` <CA+7ShCrB_1Q=aKw5sP5hLkM1o0v-P1WR5+1iL983X7WQCHP=oQ@mail.gmail.com>
2013-02-03  3:31     ` Junio C Hamano
     [not found]       ` <CA+7ShCqxDKHw0dzC6ASH=qpjG_MP-QZxOyMxQmoTKhXc7ZYHuA@mail.gmail.com>
2013-02-03  4:50         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7gmqb30p.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=cjsthompson@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).