From: Junio C Hamano <gitster@pobox.com>
To: Mike Coleman <tutufan@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: possible 'git --dirstat=0' buglet in 1.7.0.4?
Date: Tue, 16 Nov 2010 10:05:06 -0800 [thread overview]
Message-ID: <7v7hgdi1pp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTi=wZ8MhU0NUw9as-kw8Lhr=TFBK2BY7MFRQvOct@mail.gmail.com> (Mike Coleman's message of "Fri\, 12 Nov 2010 08\:33\:56 -0600")
Mike Coleman <tutufan@gmail.com> writes:
> I noticed just now that the '--dirstat=0' flag still seems to filter
> out some diffs, even though I would expect the '0' to mean "don't
> filter anything". If there's another flag that says "don't filter", I
> missed it. Could this be a rounding or off-by-one error?
We seem to internally compute in per-mille (see gather_dirstat() in diff.c)
so if your changes are too small to be rounded off to zero there,...
I think you can remove the "if (permille)" there to make it not filter at
all when dir->percent is set to 0, but I didn't look carefully.
prev parent reply other threads:[~2010-11-16 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 14:33 possible 'git --dirstat=0' buglet in 1.7.0.4? Mike Coleman
2010-11-16 18:05 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7hgdi1pp.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tutufan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).