* possible 'git --dirstat=0' buglet in 1.7.0.4?
@ 2010-11-12 14:33 Mike Coleman
2010-11-16 18:05 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Mike Coleman @ 2010-11-12 14:33 UTC (permalink / raw)
To: git
I noticed just now that the '--dirstat=0' flag still seems to filter
out some diffs, even though I would expect the '0' to mean "don't
filter anything". If there's another flag that says "don't filter", I
missed it. Could this be a rounding or off-by-one error?
Mike
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: possible 'git --dirstat=0' buglet in 1.7.0.4?
2010-11-12 14:33 possible 'git --dirstat=0' buglet in 1.7.0.4? Mike Coleman
@ 2010-11-16 18:05 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2010-11-16 18:05 UTC (permalink / raw)
To: Mike Coleman; +Cc: git
Mike Coleman <tutufan@gmail.com> writes:
> I noticed just now that the '--dirstat=0' flag still seems to filter
> out some diffs, even though I would expect the '0' to mean "don't
> filter anything". If there's another flag that says "don't filter", I
> missed it. Could this be a rounding or off-by-one error?
We seem to internally compute in per-mille (see gather_dirstat() in diff.c)
so if your changes are too small to be rounded off to zero there,...
I think you can remove the "if (permille)" there to make it not filter at
all when dir->percent is set to 0, but I didn't look carefully.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-16 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-12 14:33 possible 'git --dirstat=0' buglet in 1.7.0.4? Mike Coleman
2010-11-16 18:05 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).