From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>,
git@vger.kernel.org, "Holger Weiß" <holger@zedat.fu-berlin.de>
Subject: Re: [PATCH/RESEND] gitweb: Fix snapshots requested via PATH_INFO
Date: Mon, 20 Apr 2009 03:41:07 -0700 [thread overview]
Message-ID: <7v7i1fip4s.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <m3iqkzps96.fsf@localhost.localdomain> (Jakub Narebski's message of "Mon, 20 Apr 2009 02:52:48 -0700 (PDT)")
Jakub Narebski <jnareb@gmail.com> writes:
> Ping! This is quite straighforward bugfix for a new feature...
>
>> By the way, if there was check added for full path_info snapshot URL in
>> existing t/t9500-gitweb-standalone-no-errors.sh it would caught this
>> bug thanks to the
>> "Odd number of elements in hash assignment ..."
>> warning that Perl throws in this case.
>
> ... or are you waiting for test case?
Yeah, I somehow misinterpreted that you are saying you will follow up with
an additional test to cover this, and while I was waiting I got busy and
forgot.
prev parent reply other threads:[~2009-04-20 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090414104648.GA36554444@CIS.FU-Berlin.DE>
2009-04-15 6:40 ` [PATCH/RESEND] gitweb: Fix snapshots requested via PATH_INFO Junio C Hamano
2009-04-15 9:33 ` Giuseppe Bilotta
2009-04-15 10:09 ` Holger Weiß
2009-04-15 11:29 ` Giuseppe Bilotta
2009-04-15 17:34 ` Jakub Narebski
2009-04-20 9:52 ` Jakub Narebski
2009-04-20 10:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7i1fip4s.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=holger@zedat.fu-berlin.de \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).