From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] git-shortlog: respect i18n.logOutputEncoding config setting
Date: Sun, 22 Mar 2009 12:26:58 -0700 [thread overview]
Message-ID: <7v7i2h5pfh.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090322113438.GK27459@genesis.frugalware.org> (Miklos Vajna's message of "Sun, 22 Mar 2009 12:34:38 +0100")
Miklos Vajna <vmiklos@frugalware.org> writes:
> On Fri, Feb 20, 2009 at 02:12:38AM +0100, Miklos Vajna <vmiklos@frugalware.org> wrote:
>> As git-shortlog can be used as a filter as well, we do not really have
>> the encoding info to do a reencode_string(), but in case
>> i18n.logOutputEncoding is set, we can try to convert to the given value
>> from utf-8.
It is unclear what you want to say in these for lines. Do you mean "when
used to generate logs by itself this patch improves the behaviour by
making the output consistent with what "git log" does, but it does the
same mangling when used as a filter without knowing the log encoding and
potentially screw people over who have been depending on it not to convert
the encoding"? Or something else?
next prev parent reply other threads:[~2009-03-22 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 1:12 [RFC/PATCH] git-shortlog: respect i18n.logOutputEncoding config setting Miklos Vajna
2009-03-22 11:34 ` Miklos Vajna
2009-03-22 19:26 ` Junio C Hamano [this message]
2009-03-22 19:47 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7i2h5pfh.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).