From: Junio C Hamano <gitster@pobox.com>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] rebase: do not fail silently when the HEAD could not be detached
Date: Sat, 07 Feb 2009 18:26:18 -0800 [thread overview]
Message-ID: <7v7i414qb9.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090207233524.GD11623@atjola.homenet> (Björn Steinbrink's message of "Sun, 8 Feb 2009 00:35:24 +0100")
Björn Steinbrink <B.Steinbrink@gmx.de> writes:
> On 2009.02.07 18:20:09 +0100, Johannes Schindelin wrote:
>> Since 6fd2f5e(rebase: operate on a detached HEAD), rebase operates on a
>> detached HEAD. However, it used "checkout -q" to detach the HEAD, which
>> hid an error message when, say, an untracked file would have to be
>> overwritten to detach the HEAD.
>
> Hm, in 324c2c317 "git-rebase: report checkout failure", that was
> switched from a stdout/stderr redirect to -q, so that those error
> messages are shown. And with a quick test, rebase/checkout complains
> just fine:
Very interesting.
Dscho, how did you get the "important part of error information is hidden"
failure that led to this patch? Did it come from code inspection and
speculation alone, or was there an actual failure case?
If I apply the patch t/t3400-rebase.sh from your message alone to
'master', it does seem to pass.
next prev parent reply other threads:[~2009-02-08 2:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1234027102u.git.johannes.schindelin@gmx.de>
2009-02-07 17:20 ` [PATCH] rebase: do not fail silently when the HEAD could not be detached Johannes Schindelin
2009-02-07 21:45 ` Junio C Hamano
2009-02-07 23:35 ` Björn Steinbrink
2009-02-08 2:26 ` Junio C Hamano [this message]
2009-02-08 10:27 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7i414qb9.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).