From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, sverre@rabbelier.nl
Subject: Re: [PATCH v2 1/2] git-am: emit usage when called w/o arguments and w/o patch on stdin
Date: Wed, 28 Jan 2009 10:10:43 -0800 [thread overview]
Message-ID: <7v7i4fti70.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <76718490901280628y3761b41dhd2e544093e01e209@mail.gmail.com> (Jay Soffian's message of "Wed, 28 Jan 2009 09:28:50 -0500")
Jay Soffian <jaysoffian@gmail.com> writes:
> On Tue, Jan 27, 2009 at 11:17 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Jay Soffian <jaysoffian@gmail.com> writes:
>>
>>> + test $# = 0 && test -t 0 && usage
>>
>> Sorry to be dense. Why isn't your patch the above single liner?
>>
>
> "Also ensure that $dotest is cleaned up if user manages to interupt mailsplit
> while it is processing input, but not if mailsplit exits non-zero due to
> error."
My point was why "Also" needs to be in the same commit. Aren't they
separate issues?
prev parent reply other threads:[~2009-01-28 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 3:27 [PATCH v2 1/2] git-am: emit usage when called w/o arguments and w/o patch on stdin Jay Soffian
2009-01-28 3:27 ` [PATCH v2 2/2] git-am: minor cleanups Jay Soffian
2009-01-28 4:18 ` Junio C Hamano
2009-01-28 14:26 ` Jay Soffian
2009-01-28 4:17 ` [PATCH v2 1/2] git-am: emit usage when called w/o arguments and w/o patch on stdin Junio C Hamano
2009-01-28 10:32 ` Sverre Rabbelier
2009-01-28 14:28 ` Jay Soffian
2009-01-28 18:10 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7i4fti70.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=sverre@rabbelier.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).