From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Stephan Beyer <s-beyer@gmx.net>,
git@vger.kernel.org, Paolo Bonzini <bonzini@gnu.org>,
Miklos Vajna <vmiklos@frugalware.org>,
"Shawn O. Pearce" <spearce@spearce.org>,
Daniel Barkalow <barkalow@iabervon.org>,
Christian Couder <chriscool@tuxfamily.org>,
gitster@pobox.com
Subject: Re: [PATCH 1/2] Move run_hook() from builtin-commit.c into run-command.c (libgit)
Date: Thu, 15 Jan 2009 14:59:39 -0800 [thread overview]
Message-ID: <7v7i4wqioz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.DEB.1.00.0901151637590.3586@pacific.mpi-cbg.de
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Thu, 15 Jan 2009, Stephan Beyer wrote:
>
>> Stripping out a libified version seemed better to me than
>> copy and paste.
>
> Oh, definitely.
>
>> - ret = start_command(&hook);
>> - if (ret) {
>> - warning("Could not spawn %s", argv[0]);
>> - return ret;
>> - }
>> - ret = finish_command(&hook);
>> - if (ret == -ERR_RUN_COMMAND_WAITPID_SIGNAL)
>> - warning("%s exited due to uncaught signal", argv[0]);
>
> What are the side effects of replacing this with "ret =
> run_command(&hook);"? This has to be discussed and defended in the commit
> message.
I think the answer is "Lost warnings here and there".
next prev parent reply other threads:[~2009-01-15 23:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 15:00 [PATCH 1/2] Move run_hook() from builtin-commit.c into run-command.c (libgit) Stephan Beyer
2009-01-15 15:00 ` [PATCH 2/2] api-run-command.txt: talk about run_hook() Stephan Beyer
2009-01-15 15:49 ` Jakub Narebski
2009-01-15 16:12 ` Miklos Vajna
2009-01-15 15:46 ` [PATCH 1/2] Move run_hook() from builtin-commit.c into run-command.c (libgit) Johannes Schindelin
2009-01-15 22:59 ` Junio C Hamano [this message]
2009-01-16 17:25 ` Stephan Beyer
2009-01-16 19:09 ` [PATCH v2 1/5] checkout: don't crash on file checkout before running post-checkout hook Stephan Beyer
2009-01-16 19:09 ` [PATCH v2 2/5] Move run_hook() from builtin-commit.c into run-command.c (libgit) Stephan Beyer
2009-01-16 19:10 ` [PATCH v2 3/5] api-run-command.txt: talk about run_hook() Stephan Beyer
2009-01-16 19:10 ` [PATCH v2 4/5] run_hook(): check the executability of the hook before filling argv Stephan Beyer
2009-01-16 19:10 ` [PATCH 5/5] run_hook(): allow more than 9 hook arguments Stephan Beyer
2009-01-16 21:05 ` Johannes Schindelin
2009-01-17 3:02 ` [PATCH v2 " Stephan Beyer
2009-01-18 1:56 ` [PATCH v2 1/5] checkout: don't crash on file checkout before running post-checkout hook Junio C Hamano
2009-01-18 2:05 ` Stephan Beyer
2009-01-16 20:58 ` [PATCH 1/2] Move run_hook() from builtin-commit.c into run-command.c (libgit) Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7i4wqioz.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=bonzini@gnu.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=s-beyer@gmx.net \
--cc=spearce@spearce.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).