git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alexander Potashev <aspotashev@gmail.com>
Cc: "Adeodato Simó" <dato@net.com.org.es>, git@vger.kernel.org
Subject: Re: [PATCH v2 resend] git.c: make autocorrected aliases work
Date: Tue, 06 Jan 2009 00:19:09 -0800	[thread overview]
Message-ID: <7v7i58kfsy.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20090104172833.GA7139@myhost

Alexander Potashev <aspotashev@gmail.com> writes:

>> @@ -479,31 +501,22 @@ int main(int argc, const char **argv)
>> ...
>> +		was_alias = run_argv(&argc, &argv);
>> +		if (errno != ENOENT)
>>  			break;
>> +		if (was_alias) {
>>  			fprintf(stderr, "Expansion of alias '%s' failed; "
>>  				"'%s' is not a git-command\n",
>>  				cmd, argv[0]);
>>  			exit(1);
>
> Why not using 'die' here?

The code is in the context, and I do not think it is a good idea to
conflate such a change to a patch that wants to add aliases auto
correction.

While I do not think it matters too much in practice (unless existing
scripts that runs git depends on the exact error status value), there are
two differences: the message will say "fatal: " in front, and the command
exits with 128 not with 1.

  reply	other threads:[~2009-01-06  8:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-04 17:08 [PATCH] git.c: make autocorrected aliases work Adeodato Simó
2009-01-04 17:12 ` [PATCH v2] " Adeodato Simó
2009-01-04 17:16   ` [PATCH v2 resend] " Adeodato Simó
2009-01-04 17:28     ` Alexander Potashev
2009-01-06  8:19       ` Junio C Hamano [this message]
2009-01-06  8:19     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7i58kfsy.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=aspotashev@gmail.com \
    --cc=dato@net.com.org.es \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).