From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] git-am: propagate -C<n>, -p<n> options as well
Date: Fri, 05 Dec 2008 11:18:43 -0800 [thread overview]
Message-ID: <7v7i6e1ld8.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0812051320170.7062@intel-tinevez-2-302> (Johannes Schindelin's message of "Fri, 5 Dec 2008 13:21:43 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Thu, 4 Dec 2008, Junio C Hamano wrote:
>
>> - echo " $ws" >"$dotest/whitespace"
>> + echo " $git_apply_opt" >"$dotest/apply_opt_extra"
>
>>From the other scripts, it appears we have sort of a convention to use
> dashes instead of underscores for file names (see e.g.
> $dotest/patch-merge-tmp-dir).
You are right. And there is no reason to call it "extra" either.
git-am.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git c/git-am.sh w/git-am.sh
index 13c02d6..4b157fe 100755
--- c/git-am.sh
+++ w/git-am.sh
@@ -250,7 +250,7 @@ else
# -s, -u, -k, --whitespace, -3, -C and -p flags are kept
# for the resuming session after a patch failure.
# -i can and must be given when resuming.
- echo " $git_apply_opt" >"$dotest/apply_opt_extra"
+ echo " $git_apply_opt" >"$dotest/apply-opt"
echo "$threeway" >"$dotest/threeway"
echo "$sign" >"$dotest/sign"
echo "$utf8" >"$dotest/utf8"
@@ -288,7 +288,7 @@ if test "$(cat "$dotest/threeway")" = t
then
threeway=t
fi
-git_apply_opt=$(cat "$dotest/apply_opt_extra")
+git_apply_opt=$(cat "$dotest/apply-opt")
if test "$(cat "$dotest/sign")" = t
then
SIGNOFF=`git var GIT_COMMITTER_IDENT | sed -e '
prev parent reply other threads:[~2008-12-05 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 2:22 [PATCH 0/4] Fix longstanding "git am" bug Junio C Hamano
2008-12-05 2:22 ` [PATCH 1/4] git-am --whitespace: do not lose the command line option Junio C Hamano
2008-12-05 2:22 ` [PATCH 2/4] git-am: propagate -C<n>, -p<n> options as well Junio C Hamano
2008-12-05 2:22 ` [PATCH 3/4] git-am: propagate --3way " Junio C Hamano
2008-12-05 2:23 ` [PATCH 4/4] Test that git-am does not lose -C/-p/--whitespace options Junio C Hamano
2008-12-05 12:21 ` [PATCH 2/4] git-am: propagate -C<n>, -p<n> options as well Johannes Schindelin
2008-12-05 19:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7i6e1ld8.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).