Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Mark Burton <markb@ordern.com>,
	git@vger.kernel.org
Subject: Re: Git commit won't add an untracked file given on the command line
Date: Wed, 19 Nov 2008 15:07:33 -0800	[thread overview]
Message-ID: <7v7i6zs4ay.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LNX.1.00.0811191247560.19665@iabervon.org> (Daniel Barkalow's message of "Wed, 19 Nov 2008 13:01:04 -0500 (EST)")

Daniel Barkalow <barkalow@iabervon.org> writes:

> I don't think that's what Mark wants, in this case. He's looking for the 
> ability to have "git commit" act on a temporary index created by adding to 
> the parent commit explicitly named files which aren't in the non-temporary 
> index.

Ah, I think that it would not be an entirely unreasonable thing to do
(cf. Message-Id: <7vtza4trdp.fsf@gitster.siamese.dyndns.org>).

You can say "git add that/directory" and .gitignore mechanism protects you
from crufts in that/directory, so fearing "git commit that/directory" to
add random junk to the next commit is not a reason to fear it.

But that is a huge behaviour change.  For example, I have a handful test
scripts in my t/ directory (all named following the usual t????-*.sh
naming convention) that I do not want to commit.  Today, after making
changes to the tracked test scripts, I can rely on "git commit t/" not to
include them in the commit, and I've _learned_ to trust that behaviour.
I'd be surprised if others who have used git for more than a few months
haven't done so as well.

Allowing what Mark wants without any explicit user customization will be a
disaster to the end user experience.

  reply	other threads:[~2008-11-19 23:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-18 21:12 Git commit won't add an untracked file given on the command line Mark Burton
2008-11-18 21:27 ` Francis Galiegue
2008-11-18 21:47   ` Mark Burton
2008-11-19  1:07     ` Johannes Schindelin
2008-11-19  1:21       ` Miles Bader
2008-11-19  1:39         ` Johannes Schindelin
2008-11-19  3:43           ` Miles Bader
2008-11-19  9:41             ` Johannes Schindelin
2008-11-20  5:06               ` Miles Bader
2008-11-19  1:51       ` Junio C Hamano
2008-11-19  9:54       ` Mark Burton
2008-11-19 11:27         ` Johannes Schindelin
2008-11-19 13:22           ` Junio C Hamano
2008-11-19 14:41             ` Mark Burton
2008-11-19 18:01             ` Daniel Barkalow
2008-11-19 23:07               ` Junio C Hamano [this message]
2008-11-19 23:30                 ` Mark Burton
2008-11-19 23:51                   ` Junio C Hamano
2008-11-19 23:52                 ` Daniel Barkalow
2008-11-20  0:36                   ` Junio C Hamano
2008-11-20 10:18         ` David Aguilar
2008-11-18 22:16   ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7i6zs4ay.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=markb@ordern.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox