git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [RFC PATCH 1/5] add valgrind support in test scripts
Date: Wed, 22 Oct 2008 17:14:52 -0700	[thread overview]
Message-ID: <7v7i80tber.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0810230008430.22125@pacific.mpi-cbg.de.mpi-cbg.de> (Johannes Schindelin's message of "Thu, 23 Oct 2008 00:13:47 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi,
>
> On Wed, 22 Oct 2008, Jeff King wrote:
>
>> diff --git a/Makefile b/Makefile
>> index d6f3695..68f0172 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1343,7 +1345,12 @@ all:: $(TEST_PROGRAMS)
>>  
>>  export NO_SVN_TESTS
>>  
>> -test: all
>> +valgrind-setup: $(patsubst %.sh,%,$(VALGRIND_SH))
>> +	rm -rf t/valgrind/bin
>> +	mkdir t/valgrind/bin
>> +	for i in git $(PROGRAMS); do cp test-valgrind t/valgrind/bin/$$i; done
>
> I wonder if it would not be better to scrap the t/valgrind/ directory and 
> regenerate it everytime you run a test manually; I'd use "ln" instead of 
> "cp", and also parse command-list.txt to catch really all of them (even if 
> a dashed form is used for a builtin by mistake).

Going one step further, I wonder if this approach can also be used to
catch such a mistake.  Install a dashed form that records the fact that it
was called when it shouldn't, and by whom.

  reply	other threads:[~2008-10-23  0:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 20:28 [RFC PATCH 0/5] valgrind in test scripts Jeff King
2008-10-22 20:29 ` [RFC PATCH 1/5] add valgrind support " Jeff King
2008-10-22 22:13   ` Johannes Schindelin
2008-10-23  0:14     ` Junio C Hamano [this message]
2008-10-23 15:29       ` Jeff King
2008-10-23 15:19     ` Jeff King
2008-10-22 20:30 ` [RFC PATCH 2/5] valgrind: ignore ldso errors Jeff King
2008-10-22 20:30 ` [RFC PATCH 3/5] correct cache_entry allocation Jeff King
2008-10-22 20:31 ` [RFC PATCH 4/5] pack-objects: avoid reading uninitalized data Jeff King
2008-10-23  1:11   ` Nicolas Pitre
2008-10-23 15:33     ` Jeff King
2008-10-23 16:47       ` Nicolas Pitre
2008-10-22 20:32 ` [RFC PATCH 5/5] fix overlapping memcpy in normalize_absolute_path Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7i80tber.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).