git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Petr Baudis <pasky@suse.cz>,
	Alan.Brunelle@hp.com, linux-kernel@vger.kernel.org,
	git@vger.kernel.org
Subject: Re: Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected
Date: Fri, 22 Aug 2008 14:05:21 -0700	[thread overview]
Message-ID: <7v7ia8ahgu.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080822105136.a8432875.akpm@linux-foundation.org> (Andrew Morton's message of "Fri, 22 Aug 2008 10:51:36 -0700")

Andrew Morton <akpm@linux-foundation.org> writes:

> On Fri, 22 Aug 2008 19:16:51 +0200
> Petr Baudis <pasky@suse.cz> wrote:
>
>> On Fri, Aug 22, 2008 at 09:25:49AM -0700, Andrew Morton wrote:
> ...
>> > urgh, it's irritating when git-bisect directs you to a merge commit - it
>> > hasn't done it for me for ages.
>> 
>> Hmm, but doesn't that happen only when it's actually really the merge
>> commit that introduces the bug? Both parents of the merge commit were
>> marked as good by the user, so...
>
> A merge commit doesn't contain any kernel changes?  It's the individual
> commits (aka "patches") which were in that merge which broke stuff. 
> Confused.
>
> We're trying to dive inside that merge commit to find out which of the
> real commits caused the regression.

You may find neither parents were buggy, but the result of the merge is.

A trivial example is when one branch changes the semantics of an existing
function and converts all the call sites to the updated semantics, while
the other branch adds a new call site that still relies on the old
behaviour of that function.  The merge most likely won't textually
conflict, and neither git merge nor quilt patch would report conflicts,
but the end result is that the new call site added by the latter branch
now gets an unexpected outcome from the function and can misbehave.  You
cannot blame the breakage to either branch for such a breakage.

  parent reply	other threads:[~2008-08-22 21:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <48A36838.3050309@hp.com>
     [not found] ` <20080819124602.9e8e69f7.akpm@linux-foundation.org>
     [not found]   ` <48AEDD3D.4060507@hp.com>
2008-08-22 16:25     ` Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected Andrew Morton
2008-08-22 17:16       ` Petr Baudis
2008-08-22 17:51         ` Andrew Morton
2008-08-22 18:07           ` Alan D. Brunelle
2008-08-22 19:37           ` Björn Steinbrink
2008-08-22 19:47             ` Alan D. Brunelle
2008-08-22 20:17               ` Alan D. Brunelle
2008-08-22 19:48             ` Jeff King
2008-08-22 21:05           ` Junio C Hamano [this message]
2008-08-22 21:16             ` Andrew Morton
2008-08-22 21:21               ` Jeff King
2008-08-22 21:36               ` Björn Steinbrink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7ia8ahgu.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Alan.Brunelle@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).