git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Robin Rosenberg <robin.rosenberg@dewire.com>, git@vger.kernel.org
Subject: Re: [JGIT PATCH 01/14] Detect path names which overflow the name length field in the index
Date: Mon, 18 Aug 2008 17:11:51 -0700	[thread overview]
Message-ID: <7v7iadlv7c.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1219103602-32222-2-git-send-email-spearce@spearce.org> (Shawn O. Pearce's message of "Mon, 18 Aug 2008 16:53:09 -0700")

"Shawn O. Pearce" <spearce@spearce.org> writes:

> C Git allows a path name to be longer than 4095 bytes by storing 4095
> into the path name length field within flags and then searching for a
> null terminator at the end of the path name, instead of relying on the
> length indicatior.

This reminds me.

In the longer term, we should make this "CE_NAMEMASK gives the real length
for sane names but otherwise we need to count" merely a property of the
on-disk index structure.  In-core index should gain a new ce_namelen field
that records the real name (even when it is longer than the mask would
permit).  IOW, the knowledge of CE_NAMEMASK should be confined to
read_index_from() and ce_write_entry().

I expect this to be a relatively easy janitor project; hint, hint...

  parent reply	other threads:[~2008-08-19  0:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-18 23:53 [JGIT PATCH 00/14] TreeWalk D/F conflict detection Shawn O. Pearce
2008-08-18 23:53 ` [JGIT PATCH 01/14] Detect path names which overflow the name length field in the index Shawn O. Pearce
2008-08-18 23:53   ` [JGIT PATCH 02/14] Fix NB.decodeUInt16 to correctly handle the high byte Shawn O. Pearce
2008-08-18 23:53     ` [JGIT PATCH 03/14] Add test cases for NB.encode and NB.decode family of routines Shawn O. Pearce
2008-08-18 23:53       ` [JGIT PATCH 04/14] Fix DirCache's skip over null byte padding when reading a DIRC file Shawn O. Pearce
2008-08-18 23:53         ` [JGIT PATCH 05/14] Fix usage of assertEquals in DirCacheIteratorTest Shawn O. Pearce
2008-08-18 23:53           ` [JGIT PATCH 06/14] Refactor AbstractTreeIterator.pathCompare to force another mode Shawn O. Pearce
2008-08-18 23:53             ` [JGIT PATCH 07/14] Micro-optimize AbstractTreeIterator.pathCompare Shawn O. Pearce
2008-08-18 23:53               ` [JGIT PATCH 08/14] Optimize path comparsion within subtrees during TreeWalk Shawn O. Pearce
2008-08-18 23:53                 ` [JGIT PATCH 09/14] Refactor AbstractTreeIterator semantics to start on first entry Shawn O. Pearce
2008-08-18 23:53                   ` [JGIT PATCH 10/14] Make all AbstractTreeIterator implementations bi-directional Shawn O. Pearce
2008-08-18 23:53                     ` [JGIT PATCH 11/14] Expose beginning of iterator indication from AbstractTreeIterator Shawn O. Pearce
2008-08-18 23:53                       ` [JGIT PATCH 12/14] Allow application code to set ObjectIds in DirCacheEntry Shawn O. Pearce
2008-08-18 23:53                         ` [JGIT PATCH 13/14] Create NameConflictTreeWalk to transparently detect D/F conflicts Shawn O. Pearce
2008-08-18 23:53                           ` [JGIT PATCH 14/14] Add test case for NameConflictTreeWalk Shawn O. Pearce
2008-08-19  0:11   ` Junio C Hamano [this message]
2008-08-19 18:32   ` [JGIT PATCH 01/14] Detect path names which overflow the name length field in the index Robin Rosenberg
2008-08-19 19:57     ` Shawn O. Pearce
2008-08-19  8:52 ` [JGIT PATCH 00/14] TreeWalk D/F conflict detection David Woodhouse
2008-08-19 14:24   ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7iadlv7c.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=robin.rosenberg@dewire.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).