From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: pasky@suse.cz, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/2] sort_in_topological_order(): avoid setting a commit flag
Date: Tue, 22 Jul 2008 18:01:30 -0700 [thread overview]
Message-ID: <7v7ibdifbp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0807230150480.8986@racer> (Johannes Schindelin's message of "Wed, 23 Jul 2008 01:51:36 +0100 (BST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> This is the same behavior as before, since indegree could not be
> non-zero when TOPOSORT was unset.
>
> Incidentally, this fixes the bug in show-branch where the 8th column
> was not shown: show-branch sorts the commits in topological order,
> assuming that all the commit flags are available for show-branch's
> private matters.
Do people still actively use show-branch as a G/CUI, especially after that
"log --graph" thing was introduced?
If that is the case, it might also make sense to stop using the object
flags but allocate necessary number of bits (not restricted to 25 or so)
pointed at by commit->util field to remove its limitation.
Hint, hint...
next prev parent reply other threads:[~2008-07-23 1:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 0:50 [PATCH 1/2] Add test to show that show-branch misses out the 8th column Johannes Schindelin
2008-07-23 0:51 ` [PATCH 2/2] sort_in_topological_order(): avoid setting a commit flag Johannes Schindelin
2008-07-23 1:01 ` Junio C Hamano [this message]
2008-07-23 15:39 ` Jon Loeliger
2008-07-23 21:49 ` Petr Baudis
2008-07-23 22:07 ` Junio C Hamano
2008-07-23 19:02 ` Junio C Hamano
2008-07-23 19:33 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7ibdifbp.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).