From: Junio C Hamano <gitster@pobox.com>
To: Petr Baudis <pasky@suse.cz>
Cc: git@vger.kernel.org
Subject: Re: git-log vs git-rev-list
Date: Fri, 30 May 2008 13:28:18 -0700 [thread overview]
Message-ID: <7v7idbk04d.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20080530165641.GG18781@machine.or.cz
Petr Baudis <pasky@suse.cz> writes:
> I think that having two commands that by now do essentially the same
> thing, but slightly differently, is rather messy UI. Thus, I'm wondering
> if it would be worthwhile to make rev-list a thin git-log wrapper and
> start phasing it out?
Two answers and a half.
(1) There are a few things git-log does not do but git-rev-list is
designed to do.
(2) They are _already_ thin wrappers to the same core "revision
traversal" engine, and each of them does what it is meant to do well
as specified.
(3) rev-list is an established script interface. You could enhance it if
it does not fit your Porcelain needs, but you cannot break it, let
alone phase it out. What you can contribute is perhaps to document
it better so that casual end users do not accidentally try to use
rev-list as if it is the first class end-user interface and get
confused.
I do not think there is much to be gained by further refactoring of the
implementations between the two.
prev parent reply other threads:[~2008-05-30 20:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 16:56 git-log vs git-rev-list Petr Baudis
2008-05-30 17:25 ` Linus Torvalds
2008-05-30 19:46 ` Petr Baudis
2008-05-30 20:20 ` Linus Torvalds
2008-05-30 21:34 ` Petr Baudis
2008-05-30 20:22 ` Linus Torvalds
2008-05-30 20:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7idbk04d.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).