From: Junio C Hamano <junio@pobox.com>
To: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
Cc: git@vger.kernel.org, Martin Langhoff <martin@catalyst.net.nz>,
Frank Lichtenheld <djpig@debian.org>
Subject: Re: [PATCH 0/3] git-cvsserver: Add support for some binary files
Date: Fri, 16 May 2008 17:03:40 -0700 [thread overview]
Message-ID: <7v7idteqzn.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1210826148-8708-1-git-send-email-mmogilvi_git@miniinfo.net
Matthew Ogilvie <mmogilvi_git@miniinfo.net> writes:
> This series of patches extends git-cvsserver to support telling the
> CVS client to set the -kb (binary) mode for files that git considers
> to be binary (and not for text files). It includes updates to
> documentation and tests.
I am unfortunately not familiar with this part of the system and I'd need
to summon help from experts, but it looks rather nicely done.
I saw a few places that said "crnl" instead of "crlf" in the
documentation, which I munged locally before queuing.
I noticed kopts_from_path in patch 3/3 takes $srcType of "sha1Or-k" but I
could not spot which caller gives such token to the function.
next prev parent reply other threads:[~2008-05-17 0:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 4:35 [PATCH 0/3] git-cvsserver: Add support for some binary files Matthew Ogilvie
2008-05-15 4:35 ` [PATCH 1/3] git-cvsserver: add mechanism for managing working tree and current directory Matthew Ogilvie
2008-05-15 4:35 ` [PATCH 2/3] implement gitcvs.usecrlfattr Matthew Ogilvie
2008-05-15 4:35 ` [PATCH 3/3] git-cvsserver: add ability to guess -kb from contents Matthew Ogilvie
2008-05-17 0:03 ` Junio C Hamano [this message]
2008-05-18 22:10 ` [PATCH 0/3] git-cvsserver: Add support for some binary files Matthew Ogilvie
2008-05-18 22:38 ` Martin Langhoff
2008-05-19 7:35 ` Matthew Ogilvie
2008-05-19 9:34 ` Johannes Schindelin
2008-05-20 3:05 ` Matthew Ogilvie
2008-05-19 10:53 ` Martin Langhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7idteqzn.fsf@gitster.siamese.dyndns.org \
--to=junio@pobox.com \
--cc=djpig@debian.org \
--cc=git@vger.kernel.org \
--cc=martin@catalyst.net.nz \
--cc=mmogilvi_git@miniinfo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).