From: Junio C Hamano <gitster@pobox.com>
To: "Sverre Hvammen Johansen" <hvammen@gmail.com>
Cc: Jakub Narebski <jnareb@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 5/5] Introduce fast forward option only
Date: Fri, 25 Apr 2008 11:59:14 -0700 [thread overview]
Message-ID: <7v7ielpxq5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <m3lk32p5z9.fsf@localhost.localdomain> (Jakub Narebski's message of "Fri, 25 Apr 2008 03:46:41 -0700 (PDT)")
Jakub Narebski <jnareb@gmail.com> writes:
> "Sverre Hvammen Johansen" <hvammen@gmail.com> writes:
>
>> This feature is needed for git integration with accurev.
>> See the documentation for an explanation of this feature.
>
> I'd rather have description of the change in the commit message
> itself. You can add "See the documentation for details", but the
> basic description, like:
>
> This commit introcudes fast forward option 'only'. With --ff=only
> merge succeeds only if it resolves to fast-forward merge.
>
> It would be nice to have described either in commit message, or in the
> documentation, _why_ it is needed for integration with AccuRev,
> i.e. what features of AccuRev or of integration requires this.
Including this message, I agree with what Jakub said as comments to this
series. Readers of "git log" 6 months from now should not have to suffer
"See Documentation", and reviewers of this series right now should not
have to guess why it is a good idea and is worth reviewing by actually
reading the patch.
next prev parent reply other threads:[~2008-04-25 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 5:53 [PATCH 5/5] Introduce fast forward option only Sverre Hvammen Johansen
2008-04-25 10:46 ` Jakub Narebski
2008-04-25 18:59 ` Junio C Hamano [this message]
2008-04-25 21:00 ` Sverre Hvammen Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7ielpxq5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hvammen@gmail.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).