* What git config --replace-all ONE_ARG should do?
@ 2008-03-26 13:50 Carlos Rica
2008-03-26 21:24 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Carlos Rica @ 2008-03-26 13:50 UTC (permalink / raw)
To: Git Mailing List
The command 'git config --replace-all ONE_ARG' currently
tries to do the same as the command 'git config NAME VALUE',
using --replace-all as the NAME and ONE_ARG as VALUE,
printing "key does not contain a section: --replace-all".
What this command should do? I'm almost finnishing
buitin-config.c to use parse-options and I need to know
if that command should do something or just showing
the help and exit in such case.
I think that --replace-all should always receive at least
two arguments. The documentation currently says:
git-config ... --replace-all name [value [value_regex]]
and current tests are only cheking two arguments.
Since I cannot imagine a consistent action to do
when only the name is given and nobody complains
I will do this to print the help message and exit.
Cheers
--
Carlos
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: What git config --replace-all ONE_ARG should do?
2008-03-26 13:50 What git config --replace-all ONE_ARG should do? Carlos Rica
@ 2008-03-26 21:24 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2008-03-26 21:24 UTC (permalink / raw)
To: Carlos Rica; +Cc: Git Mailing List
"Carlos Rica" <jasampler@gmail.com> writes:
> The command 'git config --replace-all ONE_ARG' currently
> tries to do the same as the command 'git config NAME VALUE',
> using --replace-all as the NAME and ONE_ARG as VALUE,
> printing "key does not contain a section: --replace-all".
That sounds silly, and I think it is an improvement to error out in such a
case.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-26 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-26 13:50 What git config --replace-all ONE_ARG should do? Carlos Rica
2008-03-26 21:24 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).