From: Junio C Hamano <gitster@pobox.com>
To: Petr Baudis <pasky@suse.cz>
Cc: Yann Dirson <ydirson@altern.org>, GIT list <git@vger.kernel.org>
Subject: Re: Repository corruption
Date: Sun, 16 Mar 2008 16:14:10 -0700 [thread overview]
Message-ID: <7v7ig2feil.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080316230151.GB6803@machine.or.cz> (Petr Baudis's message of "Mon, 17 Mar 2008 00:01:51 +0100")
Petr Baudis <pasky@suse.cz> writes:
> My idea I got few days ago when looking at the borken repositories is
> that it was caused by interrupted git-repack, since there were stale
> tmp_pack* files left in the repository - it seems like it removed old
> "redundant" packs even though the new one weren't properly completed.
> But that is just a speculation, and I did not get around to look at the
> script yet whether this could really happen, or if something like this
> got fixed recently.
Hmm, unless you are talking about ef07618 (git-repack: Properly abort in
corrupt repository, 2005-11-21) as "recent", I do not see anything
suspicious.
We may want to refine the first comment in the remove-redundant loop to
clarify, though. We do check if elements of $existing are actually
redundant or not in the loop against $fullbases these days, since ce85907
(Only repack active packs by skipping over kept packs., 2006-10-29).
next prev parent reply other threads:[~2008-03-16 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070903165255.6CEC78B8B2@rover.dkm.cz>
[not found] ` <20070903174142.GK10749@pasky.or.cz>
[not found] ` <20070910212550.GN1935@nan92-1-81-57-214-146.fbx.proxad.net>
[not found] ` <20080315121903.GY10335@machine.or.cz>
2008-03-15 13:04 ` Repository corruption Yann Dirson
2008-03-16 5:49 ` Christian Couder
2008-03-16 23:01 ` Petr Baudis
2008-03-16 23:14 ` Junio C Hamano [this message]
2009-04-20 21:08 repository corruption John Dlugosz
2009-04-20 21:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7ig2feil.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).