From: Junio C Hamano <gitster@pobox.com>
To: "Ping Yin" <pkufranky@gmail.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] git-submodule: Make update verbose for up to date path
Date: Tue, 04 Mar 2008 12:31:03 -0800 [thread overview]
Message-ID: <7v7igi5j08.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 46dff0320803040803v2f93d749t6b45fc8e47e66d21@mail.gmail.com
"Ping Yin" <pkufranky@gmail.com> writes:
> When i run 'git submodule update' in a repository whose submodules are
> all clean, there is not any output which makes me not know whether
> this command are successful. I think this is not friendly.
Not at all. If you are unsuccessful and did not issue an error message,
you have a bug to fix.
When a command finishes successfully doing what it was asked to do,
especially when it does a lot of things and has potential to issue useful
error messages and warnings to some but not all of them, it should stay
quiet for successful ones unless there is a very good reason not to. The
reasons may include "the user told it to be chatty with --verbose", "it
may make the user think it hang, because it takes a long time", and
perhaps "it is a rare thing to run and the user may not be familiar with
how it acts".
prev parent reply other threads:[~2008-03-04 20:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 14:58 [PATCH] git-submodule: Make update verbose for up to date path Ping Yin
2008-03-04 15:04 ` Johannes Schindelin
2008-03-04 16:03 ` Ping Yin
2008-03-04 16:08 ` Johannes Schindelin
2008-03-04 20:31 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7igi5j08.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pkufranky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox