From: Junio C Hamano <gitster@pobox.com>
To: mkoegler@auto.tuwien.ac.at (Martin Koegler)
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH v3] builtin-fsck: reports missing parent commits
Date: Sun, 24 Feb 2008 23:24:55 -0800 [thread overview]
Message-ID: <7v7igto5vc.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080225071642.GA15761@auto.tuwien.ac.at> (Martin Koegler's message of "Mon, 25 Feb 2008 08:16:42 +0100")
mkoegler@auto.tuwien.ac.at (Martin Koegler) writes:
> On Sun, Feb 24, 2008 at 07:08:52PM -0800, Junio C Hamano wrote:
> ...
>> So I am not sure what problems in the repository objects these
>> new checks are designed to catch.
>>
>> This needs a lot of explanation than what's in your commit log
>> message.
>
> If we have already parsed a non-commit object and parse_commit_buffer
> hits such a sha1 in a parent line, it simply drops it (same for grafts).
>
> I hope that you agree with me, that fsck should catch such an error.
See? That's exactly my point.
You would need to _explain that_ in your commit log message.
Who on the list other than you noticed that it is what you are
checking?
prev parent reply other threads:[~2008-02-25 7:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 20:58 [PATCH v3] builtin-fsck: reports missing parent commits Martin Koegler
2008-02-25 3:08 ` Junio C Hamano
2008-02-25 7:16 ` Martin Koegler
2008-02-25 7:24 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7igto5vc.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mkoegler@auto.tuwien.ac.at \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).