From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
git@vger.kernel.org, Dane Jensen <careo@fastmail.fm>,
Pieter de Bie <pdebie@ai.rug.nl>
Subject: Re: [PATCH] hash: fix lookup_hash semantics
Date: Fri, 22 Feb 2008 12:54:24 -0800 [thread overview]
Message-ID: <7v7igw90fz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080222194726.GA24532@sigill.intra.peff.net> (Jeff King's message of "Fri, 22 Feb 2008 14:47:27 -0500")
Jeff King <peff@peff.net> writes:
> We were returning the _address of_ the stored item (or NULL)
> instead of the item itself. While this sort of indirection
> is useful for insertion (since you can lookup and then
> modify), it is unnecessary for read-only lookup.
Very nicely spotted. Thanks.
next prev parent reply other threads:[~2008-02-22 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 19:47 [PATCH] hash: fix lookup_hash semantics Jeff King
2008-02-22 20:42 ` Linus Torvalds
2008-02-22 20:54 ` Junio C Hamano [this message]
2008-02-22 22:13 ` Pieter de Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7igw90fz.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=careo@fastmail.fm \
--cc=git@vger.kernel.org \
--cc=pdebie@ai.rug.nl \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).