git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Gerrit Pape <pape@smarden.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] hash-object: don't rely on order of --stdin, -w arguments
Date: Wed, 13 Feb 2008 11:50:41 -0800	[thread overview]
Message-ID: <7v7ih8pre6.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080213190338.7393.qmail@d70c5cbe18d4bd.315fe32.mid.smarden.org> (Gerrit Pape's message of "Wed, 13 Feb 2008 19:03:38 +0000")

Gerrit Pape <pape@smarden.org> writes:

> Fix 'git hash-object --stdin -w' to actually write the object, just as
> 'git hash-object -w --stdin' does.

Can we have additions to the test scripts to illustrate:

 - what used to happen if you had "--stdin -w" on the command
   line (presumably you did not get the object written, which is
   a buggy behaviour and the patch should fix it);

 - what used to happen if you had "-w --stdin --stdin" on the
   command line (I imagine you used to be able to feed two
   separate streams when you are on a terminal by typing ^Ds in
   between?);

 - any other combination that may deserve testing.

in order to (1) show existing bugs the patch is trying to
address, (2) demonstrate that the patch fixes them without
regressing, and (3) protect the fix from being broken by future
changes, pretty please?

  reply	other threads:[~2008-02-13 19:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 19:03 [PATCH] hash-object: don't rely on order of --stdin, -w arguments Gerrit Pape
2008-02-13 19:50 ` Junio C Hamano [this message]
2008-02-13 22:49   ` [PATCH/selftest] " Gerrit Pape
2008-02-13 23:25     ` Junio C Hamano
2008-02-14 20:13       ` [PATCH] hash-object: cleanup handling of command line options Gerrit Pape
2008-02-15 17:31         ` Junio C Hamano
2008-02-21 10:06           ` Gerrit Pape

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7ih8pre6.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pape@smarden.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).