From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Joe Perches <joe@perches.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
git <git@vger.kernel.org>
Subject: Re: [PATCH] include/asm-arm/: Spelling fixes
Date: Mon, 17 Dec 2007 15:28:20 -0800 [thread overview]
Message-ID: <7v7ijc6gvf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071217230558.GD2105@coredump.intra.peff.net> (Jeff King's message of "Mon, 17 Dec 2007 18:05:58 -0500")
Jeff King <peff@peff.net> writes:
>> I wonder if stripping existing "Message-Id:" away just like we strip
>> away "Date:" from @xh would be a much saner fix.
>
> That is definitely wrong if we expect to re-use the in-reply-to and
> references headers that already exist (though obviously we could strip
> out all three of those headers and re-add our own).
Ah, you are right.
And undef $message_id you squashed in definitely belongs there --
"prepare for the next round" section.
next prev parent reply other threads:[~2007-12-17 23:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5703e57f925f31fc0eb38873bd7f10fc44f99cb4.1197918889.git.joe@perches.com>
[not found] ` <20071217195658.GB13515@fieldses.org>
[not found] ` <1197921847.27386.16.camel@localhost>
2007-12-17 20:12 ` [PATCH] include/asm-arm/: Spelling fixes J. Bruce Fields
2007-12-17 20:22 ` Joe Perches
2007-12-17 20:51 ` Jeff King
2007-12-17 21:27 ` Junio C Hamano
2007-12-17 23:05 ` Jeff King
2007-12-17 23:12 ` Jeff King
2007-12-17 23:28 ` Junio C Hamano [this message]
2008-01-08 11:15 ` Josh Triplett
2008-01-08 11:16 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7ijc6gvf.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bfields@fieldses.org \
--cc=git@vger.kernel.org \
--cc=joe@perches.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).