From: Junio C Hamano <gitster@pobox.com>
To: "Carlos Rica" <jasampler@gmail.com>
Cc: git@vger.kernel.org, "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Add tests for documented features of "git reset".
Date: Fri, 14 Sep 2007 15:10:00 -0700 [thread overview]
Message-ID: <7v7imsaog7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1b46aba20709141501l6f0f7440hd22b2bd6c4838a0b@mail.gmail.com> (Carlos Rica's message of "Sat, 15 Sep 2007 00:01:21 +0200")
"Carlos Rica" <jasampler@gmail.com> writes:
> 2007/9/11, Junio C Hamano <gitster@pobox.com>:
>> I also suspect this would not pass on CRLF boxes.
>
> I finally removed the hardcoded object IDs (patch attached,
> to be applied on top of the previous patch).
>
> But I don't know what to fix for making the test to pass
> in CRLF boxes.
The blobs created by the test script would be different on CRLF
boxes, and exact object IDs hardcoded in your test would not
match. That was the only thing I meant.
But now you bring it up, I guess the expected output may not
match as well. Hmmm..
Anyway, thanks for the update.
prev parent reply other threads:[~2007-09-14 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46E5EAE0.70603@gmail.com>
[not found] ` <7vr6l5oi4r.fsf@gitster.siamese.dyndns.org>
2007-09-14 22:01 ` [PATCH] Add tests for documented features of "git reset" Carlos Rica
2007-09-14 22:10 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7imsaog7.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jasampler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).