From: Junio C Hamano <junkio@cox.net>
To: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] entry.c: Use strerror() to print error info when possible
Date: Sun, 15 Apr 2007 15:54:47 -0700 [thread overview]
Message-ID: <7v7isd2qq0.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070415185619.3fa90f3a@gnut> (Luiz Fernando N. Capitulino's message of "Sun, 15 Apr 2007 18:56:19 -0300")
"Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
writes:
> Signed-off-by: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
> ---
> entry.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/entry.c b/entry.c
> index d72f811..c36c09d 100644
> --- a/entry.c
> +++ b/entry.c
> @@ -19,7 +19,8 @@ static void create_directories(const char *path, struct checkout *state)
> if (!stat(buf, &st) && S_ISDIR(st.st_mode))
> continue; /* ok */
> }
> - die("cannot create directory at %s", buf);
> + die("cannot create directory at %s (%s)", buf,
> + strerror(errno));
> }
> }
> free(buf);
This hunk is wrong; stat() you see in the context could have
been what failed the last before this die().
I do not think other places you patched do not share the issue.
next prev parent reply other threads:[~2007-04-15 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-15 21:56 [PATCH] entry.c: Use strerror() to print error info when possible Luiz Fernando N. Capitulino
2007-04-15 22:54 ` Junio C Hamano [this message]
2007-04-15 23:54 ` Luiz Fernando N. Capitulino
2007-04-15 23:00 ` Alex Riesen
2007-04-15 23:57 ` Luiz Fernando N. Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7isd2qq0.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=lcapitulino@mandriva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).