Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Making literal "20" symbolic
Date: Mon, 20 Nov 2006 02:54:59 -0800	[thread overview]
Message-ID: <7v7ixq4ccc.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200611201049.41024.andyparkins@gmail.com> (Andy Parkins's message of "Mon, 20 Nov 2006 11:49:35 +0100")

Andy Parkins <andyparkins@gmail.com> writes:

> I notice that there are a lot of uses of the literal 20 throughout git; I'd 
> like to change them (as appropriate) to HASH_WIDTH, or similar; and maybe 
> HASH_WIDTH_ASCII for the 40s.
>
> Is there a particular header file that is appropriate to put 
>
> #define HASH_WIDTH 20
> #define HASH_WIDTH_ASCII (HASH_WIDTH*2)
>
> Of course, I plan to review each instance to make sure I'm not changing a 
> non-hash width 20.

Probably in cache.h, close to where it defines is_null_sha1(),
hashcmp(), and friends, is the right place.

There are few places that say 42 (because we have 40-hex at the
beginning of line, followed by a single whitespace and then
something should follow so line length must be at least 42
chars), so hunting them all would be a lot of work, but I do
think this is a worthwhile cleanup.

      reply	other threads:[~2006-11-20 10:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-20 10:49 Making literal "20" symbolic Andy Parkins
2006-11-20 10:54 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7ixq4ccc.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox