git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Andy Whitcroft <apw@shadowen.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] svnimport add support for parsing From lines for author
Date: Mon, 25 Sep 2006 22:08:11 -0700	[thread overview]
Message-ID: <7v7izrtdtw.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060925110813.GA4419@shadowen.org> (Andy Whitcroft's message of "Mon, 25 Sep 2006 12:08:13 +0100")

Andy Whitcroft <apw@shadowen.org> writes:

> svnimport: add support for parsing From: lines for author

Please do _not_ repeat the summary line in the message body.  It
is on the Subject: already.

> Now that we have support for parsing Signed-off-by: for author
> information it makes sense to handle From: as well.

I take that you are referring to Sasha's change in ae35b304; I
asked for actual svn users for ACK/NACK but I did not hear any.
Can I understand that you use svnimport for real projects and
are happy with Sasha's change? --- that would be an ack that
would help me sleep better ;-).

> adds a new -F which will handle From: lines in the comments.  It
> may be used in combination with -S.

This sort of makes sense but how common is this?

I also wonder instead of piling up custom flags if it is better
to let match-and-extract pattern be specified from the command
line.

  reply	other threads:[~2006-09-26  5:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-25 11:08 [PATCH] svnimport add support for parsing From lines for author Andy Whitcroft
2006-09-26  5:08 ` Junio C Hamano [this message]
2006-09-26  7:51   ` Andy Whitcroft
2006-09-27  5:34     ` Junio C Hamano
2006-09-28 10:58       ` Andy Whitcroft
2006-09-28 16:10         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7izrtdtw.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=apw@shadowen.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).